Re: [UPDATE] lang/erlang 25.0.4

Hello,

On 2022/08/23 18:27:21 +0200, Volker Schlecht <openbsd-ports@schlecht.dev> wrote:
> Attached diff updates lang/erlang to 25.0.4.
> This is a bugfix release, bumping erts to 13.0.4 and kernel to 8.4.2
>
> rebar3, elixir and rabbitmq build and run fine on amd64 with this update.
>
> I'm also attaching an alternative patch adding me as maintainer. If
> there's no objections, I'd be happy to take care of the erlang port for
> the time being.

is lang/erlang/25,-wx now picking up wxWidgets-webkit too?

: checking for wxwidgets webview... yes

that sadly isn't available on all architecture. (assuming it builds
without the webkit libs -- haven't tried) we either do something like
the following to register the deps only on some arches, or just make
erlang not available on alpha, arm and hhpa.

.if ${MACHINE_ARCH} != "alpha" && ${MACHINE_ARCH} != "arm" && \
${MACHINE_ARCH} != "hppa"
LIB_DEPENDS-wx +=x11/wxWidgets,-webkit
WANTLIB-wx += wx_gtk3u_webview-3.0
.endif

otherwise diff looks good and works as intended, i rebuild
successfully rebar3 and elixir, so fwiw it's OK for me.

there's just one additional minor nitpick: Makefile.inc is included in
erlang/21 too, so by setting the maintainer there you need to bump the
revision on erlang/21 too since the package changes.

here's a cumulative diff with the bump but without fixing WANTLIB/LDEPS

Index: Makefile.inc
===================================================================
RCS file: /home/cvs/ports/lang/erlang/Makefile.inc,v
retrieving revision 1.26
diff -u -p -r1.26 Makefile.inc
--- Makefile.inc 12 Jul 2022 20:45:15 -0000 1.26
+++ Makefile.inc 27 Aug 2022 10:24:42 -0000
@@ -9,6 +9,8 @@ HOMEPAGE = https://www.erlang.org/
MASTER_SITES = https://github.com/erlang/otp/releases/download/OTP-${V}/
MAJ_V = ${V:C/\.[0-9]+//g}

+MAINTAINER = Volker Schlecht <openbsd-ports@schlecht.dev>
+
DISTFILES ?= ${DISTNAME}.tar.gz \
otp_doc_man_${V}.tar.gz

Index: 21/Makefile
===================================================================
RCS file: /home/cvs/ports/lang/erlang/21/Makefile,v
retrieving revision 1.12
diff -u -p -r1.12 Makefile
--- 21/Makefile 11 Jul 2022 22:29:08 -0000 1.12
+++ 21/Makefile 27 Aug 2022 10:26:37 -0000
@@ -6,7 +6,8 @@ COMMENT-wx= WxWidgets bindings for Erlan
PORTROACH= limit:^OTP-21\.

V= 21.3.8.24
-REVISION-main= 0
+REVISION-main= 1
+REVISION-wx= 0
DISTNAME= otp_src_$V
PKGNAME= erlang-$V
PKGNAME-main= erlang-$V
Index: 25/Makefile
===================================================================
RCS file: /home/cvs/ports/lang/erlang/25/Makefile,v
retrieving revision 1.2
diff -u -p -r1.2 Makefile
--- 25/Makefile 30 Jul 2022 21:48:39 -0000 1.2
+++ 25/Makefile 27 Aug 2022 10:24:42 -0000
@@ -3,7 +3,7 @@ BROKEN-alpha= beam/erl_process.c:6692: i
COMMENT-main= ${COMMENT}
COMMENT-wx= WxWidgets bindings for Erlang

-V= 25.0.3
+V= 25.0.4
PORTROACH= limit:^OTP-25\.
DISTNAME= otp_src_$V
PKGNAME= erlang-$V
@@ -71,7 +71,7 @@ EUNIT_VSN 2.7.1 \
FTP_VSN 1.1.1 \
INETS_VSN 8.0 \
JINTERFACE_VSN 1.13 \
-KERNEL_VSN 8.4.1 \
+KERNEL_VSN 8.4.2 \
MEGACO_VSN 4.4 \
MNESIA_VSN 4.21.1 \
OBSERVER_VSN 2.12 \
@@ -91,6 +91,6 @@ TFTP_VSN 1.0.3 \
TOOLS_VSN 3.5.3 \
WX_VSN 2.2 \
XMERL_VSN 1.3.29 \
-ERTS_VSN 13.0.3
+ERTS_VSN 13.0.4

.include <bsd.port.mk>
Index: 25/distinfo
===================================================================
RCS file: /home/cvs/ports/lang/erlang/25/distinfo,v
retrieving revision 1.2
diff -u -p -r1.2 distinfo
--- 25/distinfo 30 Jul 2022 21:48:39 -0000 1.2
+++ 25/distinfo 27 Aug 2022 10:24:42 -0000
@@ -1,4 +1,4 @@
-SHA256 (otp_doc_man_25.0.3.tar.gz) = LoKpVP1i9ZYEW+YK1xIKMfg0HJra3wNCY7ryp+QhdSg=
-SHA256 (otp_src_25.0.3.tar.gz) = DXVYvBbz5rYZZFIeAVfhp1qtF3C7CK8QNm6kyDRB7Cg=
-SIZE (otp_doc_man_25.0.3.tar.gz) = 1710319
-SIZE (otp_src_25.0.3.tar.gz) = 103227467
+SHA256 (otp_doc_man_25.0.4.tar.gz) = 1ffoJazAci62TVBkiP7L0fd1pWxR2XENrSAD3rbggYo=
+SHA256 (otp_src_25.0.4.tar.gz) = j8cH+SoSSyrrD2Xc+ayOJ7KjBee8xMwbL993DuwBZb8=
+SIZE (otp_doc_man_25.0.4.tar.gz) = 1710334
+SIZE (otp_src_25.0.4.tar.gz) = 103213092