Re: usbhidaction(1) is unvel(2)ed too strictly to run programs.

ouch, how did I miss the call to execl(3) on docmd()? silly me!

OK?

Index: usbhidaction.c
===================================================================
RCS file: /cvs/src/usr.bin/usbhidaction/usbhidaction.c,v
retrieving revision 1.24
diff -u -p -u -r1.24 usbhidaction.c
--- usbhidaction.c 15 Dec 2021 11:23:09 -0000 1.24
+++ usbhidaction.c 1 Aug 2022 11:08:31 -0000
@@ -166,6 +166,8 @@ main(int argc, char **argv)

if (unveil(conf, "r") == -1)
err(1, "unveil %s", conf);
+ if (unveil(_PATH_BSHELL, "x") == -1)
+ err(1, "unveil %s", _PATH_BSHELL);
if (unveil(NULL, NULL) == -1)
err(1, "unveil");



On 15:42 Sat 30 Jul , Theo de Raadt wrote:
> I suspect it should unveil("/", "x")
>
> It is better than not doing anything.
>