Re: maintainer update net/gajim 1.3.3 --> 1.4.7

On Mon, Sep 05, 2022 at 06:42:19PM +0200, Paco Esteban wrote:
> On Thu, 25 Aug 2022, Paco Esteban wrote:
>
> > Hi ports@,
> >
> > This is an update of net/gajim to its latest version 1.4.7
> > There are a lot of changes for the software itself. Take a look at the
> > changelog here:
> >
> > https://dev.gajim.org/gajim/gajim/-/blob/master/ChangeLog
> >
> > On the port itself, the major change is the removal of the plugin
> > installer plugin. It's the 3rd time upstream fails to include it on the
> > tarball and, at this point, I'm a bit tired of opening the same issue
> > over again on their system, so I decided to just pack it like that and
> > add a note to the README on how to clone the plugins repostory.
> >
> > The problem is that they changed the way the plugin manifest works. Now
> > it includes a list of supported platforms, which is compared to the
> > output of sys.platform (in our case this returns "openbsd7").
> > Of course, the only included platforms on this list are "linux", "win32"
> > and "darwin", so even if we clone the plugins, they are ignored by
> > gajim.
> >
> > I tested some of the plugins (OMEMO amongs them) by just adding
> > "openbsd7" to the list of supported platforms and they just work, of
> > course, so I added that to the README too.
> >
> > Any ideas on how to fix this are welcome, but I will just leave that
> > comment on the README for the time being and be done with it, as
> > upstream does not care much for porters in general or OpenBSD in
> > particular.
> >
> > Ok to commit ?
>
> ping ?
>
> This needs the update of net/py-nbxmpp sent on a separate thread.
> Diff here again for convenience.
>
>
> diff /usr/ports
> commit - 42e691357cfc32ffab9b209c0504dc93701165d9
> path + /usr/ports
> blob - c5fb9eeb0a0806053c50a295e9964f6e8bbcc74c
> file + net/gajim/Makefile
> --- net/gajim/Makefile
> +++ net/gajim/Makefile
> @@ -1,17 +1,13 @@
> COMMENT= fully-featured XMPP client written in Python
> -MODPY_EGG_VERSION= 1.3.3
> +MODPY_EGG_VERSION= 1.4.7
> DISTNAME= gajim-${MODPY_EGG_VERSION}
> CATEGORIES= net x11
>
> HOMEPAGE= https://www.gajim.org
>
> -MAINTAINER= Paco Esteban <paco@openbsd.org>
> +MAINTAINER= Paco Esteban <paco@openbsd.org>
>
> -MASTER_SITES= ${HOMEPAGE}/downloads/1.3/
> -# upstream did not include the plugin installer on 1.3.3 again
> -# and fixed it on 1.3.3-2
> -# https://dev.gajim.org/gajim/gajim/-/issues/10719
> -DISTFILES= gajim-${MODPY_EGG_VERSION}-2${EXTRACT_SUFX}
> +MASTER_SITES= ${HOMEPAGE}/downloads/1.4/

Insted of harcoding 1.4, you can use:
${MODPY_EGG_VERSION:R}
So you don't have to change it at each release and it gives a chance to
portroach to detect an updated release.

--
Antoine