On 2022/09/23 22:49:52 +0200, Jan Klemkow <j.klemkow@wemelug.de> wrote:
> Hi,
>
> this new port contains the suckless unicode library libgrapheme.
>
> pkg/DESCR:
> libgrapheme is an extremely simple C99 library providing
> utilities for properly handling Unicode strings made up of
> user-perceived characters ('grapheme clusters') according to the
> Unicode standard. While providing convenience functions to
> operate on UTF-8-encoded strings, you can also use libgrapheme
> for any other encoding as well.
>
> ok?
Oh, that's a nice library!
Some comments about the port:
- it could also go in the textproc category
- it's missing a license comment marker before PERMIT_PACKAGE. it
seems to be ISC, nice!
- WANTLIB is not needed.
- you can avoid patch-config_mk by setting
FAKE_FLAGS= MANPREFIX=${PREFIX}/man
- i think we can simplify patch-Makefile too. what about leaving
libgrapheme.so as-is and just add the ${SO_VERSION} at
install-time? We could even do this as a rename in post-install
instead of patching. or does this prevent the library to get the
correct soname?
- i don't really like that it runs ldconfig as part of make install.
don't know if it's better, but i've seen other project doing stuff
like that only when ${DESTDIR} is not defined. Maybe we can try to
get something like this upstream?
-ldconfig || true
+test -n "${DESTDIR}" && ldconfig || true
No comments:
Post a Comment