Re: Fix cmake.port.mk python version detection

On Fri Oct 28, 2022 at 03:51:11PM +0200, Theo Buehler wrote:
> On Fri, Oct 28, 2022 at 03:40:52PM +0200, Rafael Sadowski wrote:
> > Here is a diff to fix the python detection. This fix the issues reported
> > in the "aarch64 bulk build report". If multiple versions are installed,
> > CMake always finds the correct one from lang/python.
> >
> > OK? Bulk build first?
>
> Unfortunately, that's not good enough for devel/kf5/breeze-icons.
>
> I should have said "fails to package with Python 3.10 installed" rather
> than "fails to build", sorry.

It will pick up 3.9 which is the default even if 3.10 is installed.

$ pkg_info | rg python-
python-2.7.18p10 interpreted object-oriented programming language
python-3.10.8p0 interpreted object-oriented programming language
python-3.9.15p0 interpreted object-oriented programming language

...

Installing in /usr/local. Run /usr/ports/pobj/breeze-gtk-5.25.5/build-amd64/prefix.sh to set the environment for breeze-gtk.
-- Found Sass: /usr/local/bin/sassc
-- Found Python3: /usr/local/bin/python3.9 (found version "3.9.15") found components: Interpreter
Installing in /usr/local. Run /usr/ports/pobj/breeze-gtk-5.25.5/build-amd64/prefix.sh to set the environment for breeze-gtk.
-- The following RUNTIME packages have been found:

* GTKEngine, Pixmap/Pixbuf theme engine for GTK 2, <http://www.gtk.org/>
Required for GTK 2 theme

-- The following OPTIONAL packages have been found:

* Qt5Core

-- The following REQUIRED packages have been found:

* ECM (required version >= 0.0.9)
* Sass, SASS compiler, <https://sass-lang.com/>
Required for building GTK themes
* Python3
* PythonCairo
Required to render assets
* Breeze (required version >= 5.14.90)
Required to build the Breeze GTK+ styles

... x11/kde-plasma/breeze-gtk packaged fine with this cmake change.


>
> >
> > Rafael
> >
> > Index: cmake.port.mk
> > ===================================================================
> > RCS file: /cvs/ports/devel/cmake/cmake.port.mk,v
> > retrieving revision 1.77
> > diff -u -p -u -p -r1.77 cmake.port.mk
> > --- cmake.port.mk 2 Sep 2022 18:00:02 -0000 1.77
> > +++ cmake.port.mk 28 Oct 2022 09:30:22 -0000
> > @@ -63,9 +63,9 @@ MAKE_ENV += JAVA_HOME=${JAVA_HOME}
> > # Python
> > .if ${MODULES:Mlang/python}
> > # https://cmake.org/cmake/help/latest/module/FindPython3.html#artifacts-specification
> > -CONFIGURE_ARGS += -DPYTHON_EXECUTABLE=${MODPY_BIN}
> > -CONFIGURE_ARGS += -DPYTHON_LIBRARY_DIRS=${MODPY_LIBDIR}
> > -CONFIGURE_ARGS += -DPYTHON_INCLUDE_DIR=${MODPY_INCDIR}
> > +CONFIGURE_ARGS += -DPython${MODPY_MAJOR_VERSION}_EXECUTABLE=${MODPY_BIN}
> > +CONFIGURE_ARGS += -DPython${MODPY_MAJOR_VERSION}_LIBRARY_DIRS=${MODPY_LIBDIR}
> > +CONFIGURE_ARGS += -DPython${MODPY_MAJOR_VERSION}_INCLUDE_DIR=${MODPY_INCDIR}
> > .endif
> >
> > # Lua
> >