Hi,
Thank you! This is weird: tests passed on
my side. I will double check this evening
just to be sure.
This codeberg.org/gruf/go-ulid module has
been given me headaches. See:
https://marc.info/?l=openbsd-ports&m=166534427330832&w=2
I have still no clue about what's happening
here.
Regards,
Hukadan
Le 2022-10-19 09:50, Omar Polo a écrit :
> Hi!
>
> On 2022/10/18 21:30:05 +0200, Hukadan <me@hukadan.org> wrote:
>> Hi @ports,
>>
>> Here is an update for gotosocial. Sorry for
>> the delay since the last update.
>>
>> I added a do-test target and put the MAKE_ENV
>> needed for those tests just above. I am not sure
>> this is where they belong but portcheck did not
>> complain.
>>
>> I also added a MODGO_LDFLAGS so the version
>> of GtS is displayed on the homepage.
>>
>> Release notes:
>> https://github.com/superseriousbusiness/gotosocial/releases/tag/v0.5.2
>> https://github.com/superseriousbusiness/gotosocial/releases/tag/v0.5.1
>> https://github.com/superseriousbusiness/gotosocial/releases/tag/v0.5.0
>> https://github.com/superseriousbusiness/gotosocial/releases/tag/v0.4.0
>> https://github.com/superseriousbusiness/gotosocial/releases/tag/v0.3.8
>>
>> There was a lot of improvements such as a
>> user settings panel and shared boxes.
>>
>> I have been running the latest version for
>> more than a week without issue.
>
> Thanks! I've committed it with some minor tweaks, comments below:
>
>> diff --git a/www/gotosocial/Makefile b/www/gotosocial/Makefile
>> index dba15d35662..b26fbd6e8e9 100644
>> --- a/www/gotosocial/Makefile
>> +++ b/www/gotosocial/Makefile
>> @@ -4,7 +4,7 @@ ONLY_FOR_ARCHS = amd64
>> COMMENT = ActivityPub social network server
>>
>> MODGO_MODNAME = github.com/superseriousbusiness/gotosocial
>> -MODGO_VERSION = v0.3.7
>> +MODGO_VERSION = v0.5.2
>> REVISION = 0
>
> Revision starts as '' (empty string), so when bumping the version just
> delete it.
>
>> DISTNAME = gotosocial-${MODGO_VERSION}
>> @@ -28,6 +28,8 @@ MODULES = lang/go
>>
>> WRKDIST = ${WRKSRC}
>>
>> +MODGO_LDFLAGS += -X 'main.Version=${MODGO_VERSION:S/v//}p${REVISION}'
>> +
>
> so i've dropped the p${REVISION} part here too.
>
>> PREFIX = ${VARBASE}
>> INSTDIR = ${PREFIX}/gotosocial
>>
>> @@ -51,6 +53,13 @@ do-install:
>> ${INSTALL_DATA_DIR} ${INSTDIR}/storage
>> cp -R ${WRKDIR}/web ${INSTDIR}
>>
>> +# for test purposes only
>> +MAKE_ENV += GTS_DB_TYPE="sqlite"
>> +MAKE_ENV += GTS_DB_ADDRESS=":memory:"
>
> usually, variables are defined before targets. Also, for tests please
> use TEST_ENV that is more appropriate in this case.
>
>> +do-test:
>> + cd ${WRKSRC} && \
>> + ${MODGO_TEST_CMD} -count 1 ./...
>> +
>
> This fails for me, and since it has the same behavior of the default
> MODGO_TEST_TARGET, i dropped this bit and added a comment that test
> fails. (i did not consider this a blocker for the update)
>
> I get:
>
> ===> Regression tests for gotosocial-0.5.2
> cd
> /usr/ports/pobj/gotosocial-0.5.2/github.com/superseriousbusiness/gotosocial@v0.5.2
> && /usr/bin/env -i GO386=softfloat
> GOCACHE="/usr/ports/pobj/gotosocial-0.5.2/go-cache"
> TMPDIR="/usr/ports/pobj/gotosocial-0.5.2/build-amd64"
> GOPROXY=file:///usr/ports/pobj/gotosocial-0.5.2/go_modules
> GO111MODULE=on
> GOPATH="/usr/ports/pobj/gotosocial-0.5.2/go:/var/go-pkg"
> PORTSDIR="/home/ports" LIBTOOL="/usr/bin/libtool"
> CCACHE_DIR=/usr/ports/pobj/.ccache
> PATH='/usr/ports/pobj/gotosocial-0.5.2/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11R6/bin'
> PREFIX='/var' LOCALBASE='/usr/local' X11BASE='/usr/X11R6'
> CFLAGS='-O2 -pipe' TRUEPREFIX='/var' DESTDIR=''
> HOME='/gotosocial-0.5.2_writes_to_HOME' PICFLAG="-fpic" BINGRP=bin
> BINOWN=root BINMODE=755 NONBINMODE=644 DIRMODE=755 INSTALL_COPY=-c
> INSTALL_STRIP= MANGRP=bin MANOWN=root MANMODE=644
> BSD_INSTALL_PROGRAM="/usr/ports/pobj/gotosocial-0.5.2/bin/install -c
> -m 755"
> BSD_INSTALL_SCRIPT="/usr/ports/pobj/gotosocial-0.5.2/bin/install -c -m
> 755" BSD_INSTALL_DATA="/usr/ports/pobj/gotosocial-0.5.2/bin/install
> -c -m 644"
> BSD_INSTALL_MAN="/usr/ports/pobj/gotosocial-0.5.2/bin/install -c -m
> 644"
> BSD_INSTALL_PROGRAM_DIR="/usr/ports/pobj/gotosocial-0.5.2/bin/install
> -d -m 755"
> BSD_INSTALL_SCRIPT_DIR="/usr/ports/pobj/gotosocial-0.5.2/bin/install
> -d -m 755"
> BSD_INSTALL_DATA_DIR="/usr/ports/pobj/gotosocial-0.5.2/bin/install -d
> -m 755"
> BSD_INSTALL_MAN_DIR="/usr/ports/pobj/gotosocial-0.5.2/bin/install -d
> -m 755" go test github.com/superseriousbusiness/gotosocial
> codeberg.org/gruf/go-logger/v2@v2.0.6 requires
> codeberg.org/gruf/go-middleware@v1.1.0 requires
> codeberg.org/gruf/go-ulid@v1.0.0: reading
> file:///usr/ports/pobj/gotosocial-0.5.2/go_modules/codeberg.org/gruf/go-ulid/@v/v1.0.0.mod:
> no such file or directory
No comments:
Post a Comment