Re: [new] shells/nushell

On Sat, Oct 29, 2022 at 07:07:52PM +0200, Solène Rapenne wrote:
> hi,
>
> this is a port for the shell nushell (non POSIX)
>
> - https://www.nushell.sh/
>

> MODULES = devel/cargo
> MODCARGO_BUILD_ARGS = --workspace
> MODCARGO_CRATES_KEEP += libsqlite3-sys
> LIB_DEPENDS = databases/sqlite3
>
> .include "crates.inc"
>
> CONFIGURE_STYLE = cargo
> SEPARATE_BUILD = Yes
>
> WANTLIB += c sqlite3

a remark regarding sqlite3.

by using MODCARGO_CRATES_KEEP += libsqlite3-sys, you are asking the cargo module
to keep the embedded source code of the crate (usually because the port needs to
build it to get specific things not in databases/sqlite3).

so do you really need LIB_DEPENDS + WANTLIB sqlite3 ? or do you need
MODCARGO_CRATES_KEEP because it fails to build without ?

> # for riscv64 and powerpc64, please keep: cc >= 1.0.73 and libc >= 0.2.113
> MODCARGO_CRATES_UPDATE = cc libc

this line is required when the crate normally depends to some old version of
'cc' or 'libc' (without specific support for riscv64 or powerpc64 on openbsd).

here, 'nu' depends on:
- cc 1.0.73
- libc 0.2.134

so it isn't necessary to have this line, riscv64 and powerpc64 should build
fine.

thanks.
--
Sebastien Marie