Tuesday, October 04, 2022

Re: update libfstrm

On 2022/10/04 08:28:51 +0200, Otto Moerbeek <otto@drijf.net> wrote:
> Hi,
>
> AFAIK, this does not change the ABI or API. Is there a way to easily
> check that?

/usr/src/lib/check_sym shows no dynamic export changes

% cshlib
===> fstrm
/usr/local/lib/libfstrm.so.0.0 --> /usr/ports/pobj/fstrm-0.6.1/fake-amd64/usr/local/lib/libfstrm.so.0.0
No dynamic export changes

cshlib is a sh function I stolen from jca@ (IIRC). it iterates over
SHARED_LIBS and checks the installed version against the one installed
my `make fake'.

cshlib() {
local cnt=0
local f

for f in $(make show=SHARED_LIBS); do
[ "$((cnt++ % 2))" -eq 1 ] && continue
echo '===>' $f
/usr/src/lib/check_sym /usr/local/lib/lib$f.so* \
$(make show=WRKINST)/usr/local/lib/lib$f.so*
done
}


reading the diff on github between the version confirms that there
aren't abi changes for what i can see.

fwiw the tests are also all passing :)

> Can this be committed as such?
>
> Thanks,
>
> -Otto
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/net/libfstrm/Makefile,v
> retrieving revision 1.3
> diff -u -p -r1.3 Makefile
> --- Makefile 11 Mar 2022 19:46:13 -0000 1.3
> +++ Makefile 4 Oct 2022 06:27:00 -0000
> @@ -1,6 +1,6 @@
> COMMENT= C implementation of the Frame Streams protocol
>
> -DISTNAME= fstrm-0.5.0
> +DISTNAME= fstrm-0.6.1
> CATEGORIES= net devel
>
> SHARED_LIBS += fstrm 0.0
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/net/libfstrm/distinfo,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 distinfo
> --- distinfo 2 Jun 2019 06:19:38 -0000 1.1.1.1
> +++ distinfo 4 Oct 2022 06:27:00 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (fstrm-0.5.0.tar.gz) = EO53kqhvrOHSJx3FkWUquMevaXaIOIfGn9sR8Q2hNfw=
> -SIZE (fstrm-0.5.0.tar.gz) = 470558
> +SHA256 (fstrm-0.6.1.tar.gz) = vKSsHpgqLZI8zSTM4smPTO7tUAlpRDD3P8Dc68qPCY8=
> +SIZE (fstrm-0.6.1.tar.gz) = 471218

No comments:

Post a Comment