Hi!
On 2022/10/09 19:17:00 +0200, Laurent Cheylus <foxy@free.fr> wrote:
> Hi,
>
> unless there's any objections, I'd like to take maintainership for
> net/headscale (abieber@ drops it recently).
>
> Attached an update (CVS diff) for version 0.16.4:
> - Makefile: update for version 0.16.4 and fix MODGO_LDFLAGS for
> cli.Version
> - update modules.inc and distinfo
> - update patches/patch-config-example_yaml
looks reasonable, but the diff was generated from a tree not up to
date, you're missing the commit where abieber@ dropped the
maintainership and so the makefile part doesn't apply.
another nit below:
> [...]
> Index: modules.inc
> ===================================================================
> RCS file: /cvs/ports/net/headscale/modules.inc,v
> retrieving revision 1.5
> diff -u -p -u -r1.5 modules.inc
> --- modules.inc 11 Mar 2022 19:46:03 -0000 1.5
> +++ modules.inc 9 Oct 2022 16:39:24 -0000
> @@ -1,60 +1,59 @@
> +MODGO_VERSION = v0.16.4
> +
This should be removed from modules.inc because it's already specified
in the Makefile (where it should be.) `make modgo-gen-modules'
includes MODGO_VERSION in its output I guess to ease of copy-paste,
but should be removed after adjusting the version in the Makefile.
No comments:
Post a Comment