Tuesday, October 18, 2022

Re: update sysutils/fzf --> 0.34.0

On Tue, 18 Oct 2022, Stefan Hagen wrote:

> Stefan Hagen wrote (2022-10-18 08:17 CEST):
> > Paco Esteban wrote (2022-10-17 22:54 CEST):
> > > Also, `port-lib-depends-check` says:
> > >
> > > fzf-0.34.0(sysutils/fzf):
> > > Extra: c.96 pthread.26
> > >
> > > but c and pthread are already on WANTLIB. Am I missing something ?
> > >
> > > Builds and runs ok for me on amd64. Adding edd@ in CC as maintainer.
> >
> > Yes, it wants you to *remove* them from WANTLIB.

Got it. Thanks.

> > There is a typo in the README:
> > - source /usr/local/share/fzf/bash/key_bindings.bash
> > + source /usr/local/share/fzf/bash/key-bindings.bash
> >
> > > # uses pledge()
> >
> > If you check the fzf distfile from edd, you see that he added pledge
> > support. And because we can't patch go ports, he created a distfile.
> >
> > I'd say let's stick with edds efforts as long as he's willing to carry
> > over his patch and host the distfile.

Did not notice that. Will let edd@ decide then.

> > @edd: Maybe add a comment why the distfile is used.
> >
> > Best Regards,
> > Stefan
>
> Btw. there is another fzf update thread going on this list:
> https://marc.info/?t=166513610200001&r=1&w=2

It seems I need to pay more attention to ports@ these days ...
I guess then edd@ picks and chooses and somebody commits. Let me know
if that somebody is me via any channel ;-)

Cheers,
Paco.

--
Paco Esteban.
0x5818130B8A6DBC03

No comments:

Post a Comment