Re: Add QUIC support for curl

On 2022/11/08 17:36, Theo Buehler wrote:
> And here with the ports actually attached...

OK to import ngtcp2, nghttp3

I would adjust the comment to :

# Don't pull this in as BUILD_DEPENDS to reduce dependencies on
# the path to building curl->cmake.

and there's a stray newline in ngtcp2/pkg/DESCR

> > It is hopefully acceptable to add two small dependencies to curl, but I
> > assume we need to do some testing first to make sure we don't
> > accidentally cripple an arch by breaking curl.
> >
> > I have tested this on amd64 and arm64.

They are quick to build and don't pull in a big dep chain so from that
point of view I don't think there's an issue.

Could definitely do with a spin on a base-gcc arch before adding to curl.
Other than that, I'm happy to add this to curl as long as naddy is.

If this is added to curl, I hope we don't get a bunch of ngtcp2/nghttp3
in LIB_DEPENDS when people regen WANTLIB for ports that pull in curl
(like we had with nghttp2 :)

(Also there will be some additional care with REVISION for backports
to -stable with ports around this.)

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/net/curl/Makefile,v
> retrieving revision 1.175
> diff -u -p -r1.175 Makefile
> --- Makefile 7 Nov 2022 14:37:00 -0000 1.175
> +++ Makefile 8 Nov 2022 16:06:14 -0000
> @@ -1,7 +1,7 @@
> COMMENT= transfer files with FTP, HTTP, HTTPS, etc.
>
> DISTNAME= curl-7.86.0
> -REVISION= 0
> +REVISION= 1
> SHARED_LIBS= curl 26.17 # 12.0
> CATEGORIES= net
> HOMEPAGE= https://curl.se/
> @@ -14,14 +14,16 @@ PERMIT_PACKAGE= Yes
> MASTER_SITES= https://curl.se/download/
> EXTRACT_SUFX= .tar.xz
>
> -LIB_DEPENDS= www/nghttp2
> -WANTLIB= c crypto pthread nghttp2 ssl z
> +LIB_DEPENDS= www/nghttp2 www/nghttp3 net/ngtcp2

nit, missing newlines

> +WANTLIB= c crypto pthread nghttp2 nghttp3 ngtcp2 ssl z
>
> AUTOCONF_VERSION=2.71
> CONFIGURE_STYLE=autoconf
> # Beware of circular dependency curl -> brotli -> cmake -> curl
> CONFIGURE_ARGS= --with-openssl \
> --with-ca-bundle=/etc/ssl/cert.pem \
> + --with-nghttp3 \
> + --with-ngtcp2 \
> --without-brotli \
> --without-hyper \
> --without-libgsasl \