On 2022/11/08 22:12, Stefan Hagen wrote:
> Stuart Henderson wrote (2022-11-08 20:37 WET):
> > here are some tweaks, it looks like it will be too much pain to turn
> > it into a proper python.port.mk port but we can get a bit closer and use
> > some more bits of the ports framework.
> >
> > I also wondered if it should it be installed (or aliased) to CodeChecker
> > to match the case of the usage commands etc?
>
> I don't have a hard opinion on this. Moritz preferred it lowercase and
> I think it's more common, too. But the --help output and documentation
> shows CodeChecker.
I prefer lowercase too, but the mismatch feels a bit wrong :)
> Attached is a codechecker version that incorporates sthens feedback and
> also reworks the the file handling in a way I like even better.
That allows files to get copied into WRKDIR which haven't gone through
the usual distinfo hash-checking process, I think it's better to use
the explicit filenames when copying from FULLDISTDIR (even if that
is using a subdirectory)
> I had to add PARALLEL_MAKE_FLAGS, because with sthens version of
> ALL_TARGET = package package_api, make would try to build both targets
> at the same time, which caused issues here and I had to "make" the port
> twice for it to succeed.
Do you have MAKE_JOBS set in mk.conf? You'll run into problems with
quite a few ports doing that. (If not, I don't know why it would try to
build in parallel).
No comments:
Post a Comment