Re: new: devel/codechecker static analysis infrastructure built on LLVM

On 2022/11/08 19:02, Stuart Henderson wrote:
> On 2022/11/08 19:00, Stuart Henderson wrote:
> > On 2022/11/08 19:35, Omar Polo wrote:
> > > On 2022/11/08 18:21:49 +0000, Klemens Nanni <kn@openbsd.org> wrote:
> > > > SUBST_CMD is probably better suited in post-patch.
> > >
> > > (or even pre-configure)
> >
> > post-patch is about the worst place for SUBST_CMD, it breaks
> >
> > make patch
> > <edit>
> > make update-patches
> >
> > pre-configure is way better
> >
>
> Also the python bits need work
>
> I may be able to take a look later
>

fixes for the two py-*, those two are ok sthen

codechecker to follow


diff --git devel/py-portalocker/Makefile devel/py-portalocker/Makefile
index 3bce797..44b3dc6 100644
--- devel/py-portalocker/Makefile
+++ devel/py-portalocker/Makefile
@@ -1,4 +1,4 @@
-COMMENT = is a library to provide an easy API to file locking
+COMMENT = easy Python API to file locking

MODPY_EGG_VERSION = 2.6.0

@@ -11,7 +11,7 @@ MAINTAINER = Moritz Buhl <mbuhl@openbsd.org>

HOMEPAGE = https://github.com/WoLpH/portalocker

-# PSF
+# BSD
PERMIT_PACKAGE = Yes

MODULES = lang/python
@@ -20,8 +20,10 @@ MODPY_PI = Yes
FLAVOR = python3
FLAVORS = python3

-BUILD_DEPENDS = devel/py-wheel${MODPY_FLAVOR}
-
-MODPY_PYBUILD = Yes
+MODPY_PYBUILD = setuptools
+TEST_DEPENDS = devel/py-test-cov${MODPY_FLAVOR} \
+ devel/py-test-timeout${MODPY_FLAVOR} \
+ textproc/py-sphinx${MODPY_FLAVOR} \
+ databases/py-redis${MODPY_FLAVOR}

.include <bsd.port.mk>
diff --git devel/py-portalocker/pkg/DESCR devel/py-portalocker/pkg/DESCR
index 8b01768..22eefbe 100644
--- devel/py-portalocker/pkg/DESCR
+++ devel/py-portalocker/pkg/DESCR
@@ -1 +1,4 @@
-Portalocker is a library to provide an easy API to file locking.
+Portalocker is a library to provide an easy API to file locking,
+including standard Unix filesystem locks, and a locking method based
+on Redis pubsub which allows for locks across multiple threads,
+processes and even distributed across multiple computers.
diff --git devel/py-thrift/Makefile devel/py-thrift/Makefile
index 2844f5d..f5bf1f9 100644
--- devel/py-thrift/Makefile
+++ devel/py-thrift/Makefile
@@ -3,25 +3,31 @@ COMMENT = Python bindings for the Apache Thrift RPC system
MODPY_EGG_VERSION = 0.16.0

DISTNAME = thrift-${MODPY_EGG_VERSION}
+PKGNAME = py-${DISTNAME}

CATEGORIES = devel

-HOMEPAGE = http://thrift.apache.org/
+HOMEPAGE = https://thrift.apache.org/

-# LICENSE
+# Apache 2.0
PERMIT_PACKAGE = Yes

-MODULES = lang/python
-MODPY_PI = Yes
+WANTLIB += ${COMPILER_LIBCXX} m

COMPILER= base-clang ports-gcc
-WANTLIB += ${COMPILER_LIBCXX} m
+
+MODULES = lang/python
+MODPY_PI = Yes

FLAVOR = python3
FLAVORS = python3

-BUILD_DEPENDS = devel/py-wheel${MODPY_FLAVOR}
+MODPY_PYBUILD = setuptools
+
+# tests in the pypi distfile are missing various files present in
+# https://github.com/apache/thrift/tree/master/lib/py/test
+NO_TEST = Yes

-MODPY_PYBUILD = Yes
+RUN_DEPENDS = devel/py-six${MODPY_FLAVOR}

.include <bsd.port.mk>
diff --git devel/py-thrift/pkg/DESCR devel/py-thrift/pkg/DESCR
index 4305ef0..135d584 100644
--- devel/py-thrift/pkg/DESCR
+++ devel/py-thrift/pkg/DESCR
@@ -1 +1,4 @@
-API stubs for CodeChecker.
+Python API bindings to the Apache Thrift RPC subsystem.
+
+Thrift is a framework providing communication and data serialization for
+scalable cross-language services development.