On 2022/11/08 18:21:49 +0000, Klemens Nanni <kn@openbsd.org> wrote:
> On Tue, Nov 08, 2022 at 07:07:50PM +0100, Moritz Buhl wrote:
> > Dear porters,
> >
> > codechecker is a scan-build replacement that supports cross translation
> > analysis for C.
> >
> > A huge thanks to sdk@ for the hand holding and showing me how to
> > port this.
> > We removed the web server components from the build because it would
> > use npm.
> >
> > The port and dependencies are attached.
> >
> > OK?
> > mbuhl
>
> V can be merged into GH_TAGNAME.
>
> You can use DISTDIR instead of rewriting four DISTFILES.
> Then just one DISTFILES rewrite to zap MASTER_SITES1 which is just a
> subpath of MASTER_SITES0.
>
> A few spaces after "=" and at the end of line, one missing after STATIC_DIR.
>
> `cp' should be enough in post-extract, i.e. no need for `-f'.
>
> SUBST_CMD is probably better suited in post-patch.
(or even pre-configure)
> Rerunning an interrupted build shouldn't need to substitute again.
>
> do-build should use MAKE_PROGRAM not "gmake". Then add it as build dep
> or set USE_GMAKE. 'cd d && make' can be 'make -C d'.
+1
portalocker COMMENT is also slightly wrong, I'd drop the leading "is a
library", or even
COMMENT = Python library for file locking
I'd use ${INSTALL_DATA_DIR} / ${INSTALL_DATA} instead of mkdir -p and
cp, but that's opinable.
No comments:
Post a Comment