Le Wed, Nov 30, 2022 at 12:26:37PM +0000, Stuart Henderson a écrit :
> On 2022/11/30 00:38, Giovanni Bechis wrote:
> > SCRIPTS = cas-proxy-validate.py sql-update-2.2.17_to_2.3.0.sh \
> > sql-update-3.2.10_to_4.0.0.sh sql-update-2.2.17_to_2.3.0-mysql.sh \
> > sql-update-3.2.10_to_4.0.0-mysql.sh sql-update-3.0.0-to-combined.sh \
> > - sql-update-3.0.0-to-combined-mysql.sh updates.php
> > + sql-update-3.0.0-to-combined-mysql.sh sql-update-5.5.1_to_5.6.0.sh updates.php
>
> I don't use sogo, but this doesn't seem the most sensible way to
> handle the scripts. In most cases it's better to use wildcards
> rather than try to maintain a list in the port Makefile, they nearly
> always get out of sync sooner or later.
>
> Also sql-update-5.5.1_to_5.6.0.sh has #!/bin/bash, this is patched
> in *some* of the other sql-update scripts, and the pkg-readme tells
> you to use bash in some cases but not others. It's very inconsistent.
>
> How about installing all of Scripts/sql-update-*.sh and run them
> through sed -i 's,#!/bin/bash,#!${LOCALBASE}/bin/bash,'? If some of the
> old ones are not useful they could be @comment'ed to reduce mess, but
> that seems an easier way of keeping track of new files.
seems indeed much nicer and less error-prone for the future.
Landry
No comments:
Post a Comment