Re: update devel/abseil-cpp to latest LTS 20220623.1 (could use a bulk test)

On 2022/12/01 00:17, Klemens Nanni wrote:
> https://github.com/abseil/abseil-cpp/releases/tag/20220623.1
>
> Most #ifdef OpenBSD hunks were merged, rest of the patches remains the
> same (with update churn).
>
> make test on amd64:
> 98% tests passed, 3 tests failed out of 178
>
> Total Test time (real) = 183.26 sec
>
> The following tests FAILED:
> 132 - absl_charconv_test (Failed)
> 140 - absl_str_format_convert_test (Failed)
> 167 - absl_time_test (Failed)
>
> I'll take a look at those tests tomorrow.

Build fails here:

===> Configuring for abseil-cpp-20220623.1
-- The CXX compiler identification is Clang 13.0.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/obj/ports/abseil-cpp-20220623.1/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found GTest: /usr/local/lib/cmake/GTest/GTestConfig.cmake (found version "1.11.0")
-- Configuring done
CMake Error at CMake/AbseilHelpers.cmake:300 (target_link_libraries):
The link interface of target "conformance_testing" contains:

absl::debugging

but the target was not found. Possible reasons include:

* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.

Call Stack (most recent call first):
absl/types/CMakeLists.txt:244 (absl_cc_library)


-- Generating done
CMake Warning:
Manually-specified variables were not used by the project:

CMAKE_ASM_COMPILER_AR
CMAKE_ASM_COMPILER_RANLIB
CMAKE_C_COMPILER_AR
CMAKE_C_COMPILER_RANLIB
CMAKE_Fortran_COMPILER_AR
CMAKE_Fortran_COMPILER_RANLIB
CMAKE_OBJCXX_COMPILER_AR
CMAKE_OBJCXX_COMPILER_RANLIB
CMAKE_OBJC_COMPILER_AR
CMAKE_OBJC_COMPILER_RANLIB


CMake Generate step failed. Build files cannot be regenerated correctly.

> Can someone throw this into a bulk?
>
> I have no way of testing all the consumers that came after net/tg_owt
> and net/tdesktop.

No need for a bulk, "all the consumers that came after" is just
libphonenumber.

I just fixed "make test" there; with the current version of abseil-cpp
it looks like this: 325 tests from 16 test suites ran. (7366 ms total)