Saturday, December 31, 2022

xfce4: pass --enable-debug only when DEBUG is set

xfc4-wavelan spams ~/.xsession with state changes which stems from the
xfce DBG macro which gets defined when the DEBUG macro is set, which
comes from --enable-debug that is currently passed for every port using
XFCE_COMMIT.

landry pointed out the XFCE_COMMIT/--enable-debug connection and
suggested a DEBUG test -- I failed to look at xfce4.port.mk in the first
place.

Only four ports use a commit, so bumping them is easy to pick up
potential object changes.

Feeback? Objection? OK?

Index: xfce4.port.mk
===================================================================
RCS file: /cvs/ports/x11/xfce4/xfce4.port.mk,v
retrieving revision 1.37
diff -u -p -r1.37 xfce4.port.mk
--- xfce4.port.mk 15 Dec 2022 14:43:16 -0000 1.37
+++ xfce4.port.mk 31 Dec 2022 12:12:31 -0000
@@ -79,7 +79,7 @@ PORTROACH+= limitw:1,even
.if defined(XFCE_COMMIT)
DISTNAME = ${DISTNAME_GIT}
MASTER_SITES = ${MASTER_SITES_GIT}
-CONFIGURE_ARGS += --enable-maintainer-mode --enable-debug
+CONFIGURE_ARGS += --enable-maintainer-mode
AUTOMAKE_VERSION = 1.14
AUTOCONF_VERSION = 2.69
MODXFCE4_gen = cd ${WRKSRC} && env NOCONFIGURE=yes \
@@ -89,6 +89,10 @@ BUILD_DEPENDS += ${MODGNU_AUTOCONF_DEPEN
${MODGNU_AUTOMAKE_DEPENDS} \
x11/xfce4/xfce4-dev-tools

+.endif
+
+.if defined(DEBUG)
+CONFIGURE_ARGS += --enable-debug
.endif

# remove useless .la file
Index: orage/Makefile
===================================================================
RCS file: /cvs/ports/x11/xfce4/orage/Makefile,v
retrieving revision 1.66
diff -u -p -r1.66 Makefile
--- orage/Makefile 25 Dec 2022 07:16:37 -0000 1.66
+++ orage/Makefile 31 Dec 2022 12:15:16 -0000
@@ -3,6 +3,7 @@ COMMENT= Xfce4 calendar
XFCE_VERSION= 4.17.0pre0
XFCE_COMMIT= cf27a483c40188bb
XFCE_GOODIE= orage
+REVISION= 0

# GPLv2
PERMIT_PACKAGE= Yes
Index: xfce4-mixer/Makefile
===================================================================
RCS file: /cvs/ports/x11/xfce4/xfce4-mixer/Makefile,v
retrieving revision 1.62
diff -u -p -r1.62 Makefile
--- xfce4-mixer/Makefile 21 Dec 2022 09:15:26 -0000 1.62
+++ xfce4-mixer/Makefile 31 Dec 2022 12:14:17 -0000
@@ -3,6 +3,7 @@ COMMENT= Xfce4 volume mixer
XFCE_GOODIE= xfce4-mixer
XFCE_VERSION= 4.18.0pre0
XFCE_COMMIT= a71951036481ca08a670ad8bf3cd107d37bfb774
+REVISION= 0

# GPLv2
PERMIT_PACKAGE= Yes
Index: xfce4-taskmanager/Makefile
===================================================================
RCS file: /cvs/ports/x11/xfce4/xfce4-taskmanager/Makefile,v
retrieving revision 1.41
diff -u -p -r1.41 Makefile
--- xfce4-taskmanager/Makefile 27 Dec 2022 09:14:37 -0000 1.41
+++ xfce4-taskmanager/Makefile 31 Dec 2022 12:15:24 -0000
@@ -3,7 +3,7 @@ COMMENT= Xfce4 task manager and system m
XFCE_VERSION= 1.5.5
XFCE_COMMIT= c4564879
XFCE_GOODIE= xfce4-taskmanager
-REVISION= 0
+REVISION= 1

# GPLv2
PERMIT_PACKAGE= Yes
Index: xfce4-wavelan/Makefile
===================================================================
RCS file: /cvs/ports/x11/xfce4/xfce4-wavelan/Makefile,v
retrieving revision 1.53
diff -u -p -r1.53 Makefile
--- xfce4-wavelan/Makefile 23 Dec 2022 08:03:10 -0000 1.53
+++ xfce4-wavelan/Makefile 31 Dec 2022 12:15:04 -0000
@@ -3,7 +3,7 @@ COMMENT= Xfce4 wireless interface monito
XFCE_VERSION= 0.6.3
XFCE_PLUGIN= wavelan
XFCE_COMMIT= 56657a9cc08ce4da022db9233dcf3241aaf13794
-REVISION= 4
+REVISION= 5

# BSD
PERMIT_PACKAGE= Yes

No comments:

Post a Comment