On 1/21/23 19:46, Theo Buehler wrote:
> To be clear, I'm not excluding that this is part of the solution to the
> problem. However, with this diff, I see the exact same segfault that I
> saw without any diff at all, so I do not think we should land this just
> yet.
I don't have a CPU with the PKU register, and I was using the last amd64
snapshot that didn't have this enabled as default. With that combination
it neither crashed, nor showed any of those warnings. Which is expected
behavior, I guess ...
> My suggestion for a diff that would only affect the troublesome amd64
> architecture and avoid any possible PIC issues on i386 would be the
> below:
Tested with the same hardware setup and the latest amd64 snapshot, so I
couldn't see a crash coming from xonly if there was one. But here it
works fine, so OK from me.
No comments:
Post a Comment