Hi Omar,
Le 2023-01-25 10:00, Omar Polo a écrit :
> On 2023/01/24 17:00:07 +0100, Omar Polo <op@omarpolo.com> wrote:
>> gopls is already included in go-tools, so it would conflict.
>>
>> % pkglocate bin/gopls
>> go-tools-1.12.20190226p2:devel/go-tools:/usr/local/bin/gopls
>>
>> However the latter hasn't receved much love recently. (I for one
>> forgot its existance, i have a locally installed gopls in ~/go/bin.)
>> I would agree with splitting gopls as standalone port. It would make
>> go-tools easier to update and even upstream seems to consider gopls
>> separate from the other go-tools (gopls has its own tags in the repo.)
>>
>> Otherwise your port looks ok to me, just consider this semplification
>> for post-install:
>>
>> it would also need a @conflict marker in pkg/PLIST... but let me take
>> a look at updating go-tools first.
>
> Here's a tweaked tarball that's ok op@ to import once go-tools gets
> updated. I've included my suggestion to simplify the post-install,
> reflowed DESCR so it reads better in 80x24 and added the @conflict
> marker for the current go-tools version. I've sent a diff to update
> it that also drops gopls.
Thanks for your diff, build and tests OK on amd64. Please commit if OK
for you.
I'm going to test your update for go-tools.
Laurent
No comments:
Post a Comment