And sure enough attachment was not sent, here it is
On 21:33 Thu 26 Jan , Ricardo Mestre wrote:
> This seems to have been forgotten and fell through the cracks, attached is a new
> version (3.2.8) based on port provided in this email thread. Additionally it now
> uses a proper patch instead of calling sed directly.
>
> Tested on amd64, OK to import?
>
> On 11:50 Tue 26 Jul , Stuart Henderson wrote:
> > On 2022/07/25 09:48, Omar Polo wrote:
> > > some nits:
> > >
> > > - we've dropped the RCS Ids (the $OpenBSD$ line) in ports
> > > - i'd set CATEGORIES, HOMEPAGE and MAINTAINER after GH_* as per
> > > Makefile.template
> > > - no need to set MODPY_VERSION, that's already the default
> >
> > agreed on these
> >
> > > Personally, I'd go with a patch instead of sed -i for setup.py, but even
> > > using sed -i should be fine in this case. (patches are more robust than
> > > sed for updates; they break sometimes, but at least you get the chance
> > > to see what's going on instead of blindling substituting.)
> >
> > +1 for this
> >
>
No comments:
Post a Comment