Tuesday, January 03, 2023

Re: [patch] neomutt

On Tue, Jan 03, 2023 at 05:36:24PM -0500, Jon Fineman wrote:
> I was thinking of this one. Sorry if I have folks confused. I can't find it
> in CVS due to the file rename. So I have included the git link.
>
> <https://github.com/openbsd/ports/commit/90907c5a16e53ea0d0f5d6f389153cbac355bba3>

That says "sthen committed on May 25, 2017".

The port has a maintainer (sthen) who should always be in Cc when a
change to the port is suggested. Not sure why some other person who
happens to be mentioned in a commit message > 5 years ago should be
responsible.

The sasl patches you suggest to remove are leftovers of the pledge
patches for mutt which were dropped for neomutt at some point. I can't
tell whether that removal was deliberate or an accident - the Makefile
still says # uses pledge().

The auto_def patch doesn't look like a patch that should be dropped.

In any case, if you change patches you probably need to bump REVISION.

No comments:

Post a Comment