Re: [patch] neomutt

On Tue, Jan 03, 2023 at 11:56:16PM +0000, Stuart Henderson wrote:
>On 2023/01/04 00:06, Theo Buehler wrote:
>> On Tue, Jan 03, 2023 at 05:36:24PM -0500, Jon Fineman wrote:
>> > I was thinking of this one. Sorry if I have folks confused. I can't find it
>> > in CVS due to the file rename. So I have included the git link.
>> >
>> > <https://github.com/openbsd/ports/commit/90907c5a16e53ea0d0f5d6f389153cbac355bba3>
>>
>> That says "sthen committed on May 25, 2017".
>>
>> The port has a maintainer (sthen) who should always be in Cc when a
>> change to the port is suggested. Not sure why some other person who
>> happens to be mentioned in a commit message > 5 years ago should be
>> responsible.
>>
>> The sasl patches you suggest to remove are leftovers of the pledge
>> patches for mutt which were dropped for neomutt at some point. I can't
>> tell whether that removal was deliberate or an accident - the Makefile
>> still says # uses pledge().
>
>Accidental.
>
>> The auto_def patch doesn't look like a patch that should be dropped.
>
>I think that may have been something to do with the issue fixed in
>curses.h r1.63 about wide char functions, though I'm not certain as
>just copying curses.h 1.62 doesn't cause it to fail.
>
>IIRC it was previously failing to link without that patch.
>
>I've dropped that patch. (I have some odd behaviour with display of
>my sent folders, but that's the same with/without the patch; FWIW
>I normally use mutt not neomutt).
>
>> In any case, if you change patches you probably need to bump REVISION.
>
>I've reinstated the pledge patch to main.c and tested with gpgme+sasl.
>If someone using neomutt+notmuch could give that a spin (after anoncvs
>has updated; version will be neomutt-20220429p0) and check that things
>are still ok there, it would be helpful.
>

Thanks. I saw your update and tested FLAVOR="gpgme sasl notmuch". It
builds fine and seems to run fine. No pledge crashes. My Sent folder
renders fine.

Looks good to me.