Re: [patch] sendmail: bump MaxHopCount default

Sure. Ok aja.

—
Antoine

> On 17 Jan 2023, at 18:52, Matthieu Herrb <matthieu@herrb.eu> wrote:
>
> Hi,
>
> I'm still using sendmail (and OpenBSD's package) to handle smtp at
> $DAYJOB
>
> I recently got complains from colleagues who didn't receive some
> emails from the administrative part of the University.
>
> After some digging I found out that with all the modern anti-spam and
> anti-phishing filtering that large organisations are doing, the
> missing mails arrive here with a hop count of more than 25 (sendmail's
> default value for at least 30 years) and get rejected.
>
> A bit of research show that postfix has been using 50 since
> 1999. OpenSMTPd is using 100.
>
> So the patch below (conservatively) bumps the default max hop count to
> 50. ok ?
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/OpenBSD/ports/mail/sendmail/Makefile,v
> retrieving revision 1.50
> diff -u -p -u -r1.50 Makefile
> --- Makefile 3 Oct 2022 22:33:33 -0000 1.50
> +++ Makefile 17 Jan 2023 17:35:15 -0000
> @@ -7,6 +7,7 @@ PKGNAME-main = sendmail-${V}
> PKGNAME-libmilter = libmilter-${V}
> FULLPKGNAME-libmilter = libmilter-${V}
> FULLPKGPATH-libmilter = mail/sendmail,-libmilter
> +REVISION-main = 0
>
> SHARED_LIBS = milter 4.0
>
> Index: patches/patch-cf_m4_proto_m4
> ===================================================================
> RCS file: /cvs/OpenBSD/ports/mail/sendmail/patches/patch-cf_m4_proto_m4,v
> retrieving revision 1.5
> diff -u -p -u -r1.5 patch-cf_m4_proto_m4
> --- patches/patch-cf_m4_proto_m4 11 Mar 2022 19:34:56 -0000 1.5
> +++ patches/patch-cf_m4_proto_m4 17 Jan 2023 17:31:34 -0000
> @@ -1,9 +1,18 @@
> -net/uucp uses login _uucp
> +net/uucp uses login _uucp and bump MaxHopCount
>
> Index: cf/m4/proto.m4
> --- cf/m4/proto.m4.orig
> +++ cf/m4/proto.m4
> -@@ -746,6 +746,7 @@ ifdef(`_USE_CT_FILE_', `', `#')Ft`'ifdef(`confCT_FILE'
> +@@ -307,7 +307,7 @@ _OPTION(TempFileMode, `confTEMP_FILE_MOD
> + _OPTION(MatchGECOS, `confMATCH_GECOS', `False')
> +
> + # maximum hop count
> +-_OPTION(MaxHopCount, `confMAX_HOP', `25')
> ++_OPTION(MaxHopCount, `confMAX_HOP', `50')
> +
> + # location of help file
> + O HelpFile=ifdef(`HELP_FILE', HELP_FILE, `MAIL_SETTINGS_DIR`'helpfile')
> +@@ -746,6 +746,7 @@ ifdef(`_USE_CT_FILE_', `', `#')Ft`'ifdef
> Troot
> Tdaemon
> ifdef(`_NO_UUCP_', `dnl', `Tuucp')
>
> --
> Matthieu Herrb