Re: [update][proposal] sysutils/nnn add nerd font flavor

I think I'd add something to DESCR like "Requires a terminal configured to
use a font from one of the *-nerd-fonts packages, e.g. noto-nerd-fonts or
others."

--
Sent from a phone, apologies for poor formatting.

On 1 January 2023 19:26:20 Omar Polo <op@omarpolo.com> wrote:

> On 2022/12/28 17:27:23 +0100, Joel Carnat <joel@carnat.net> wrote:
>> Here is a patch for the corrected Makefile and modified DESCR files.
>>
>> I can look at fonts/msttcorefonts and do the same thing for the Nerd Fonts.
>> But there are 53 fonts, without a popularity note. Uncompressed, they take
>> about 4GB. I only use one font and would probably not install such a huge
>> package. I don't know about others. Maybe using FULLPKGNAME like with
>> x11/windowmaker-lang would be the way to go so that one font is one package
>> and people install the one(s) they want.
>>
>> What do you think?
>
> almost forgot about nnn after importing the fonts.
>
> here's Joel' diff without the part about manually downloading the
> fonts. is it enough (pkg_info -Q nerd should find the fonts) or the
> wording needs to be improved?
>
> Index: Makefile
> ===================================================================
> RCS file: /home/cvs/ports/sysutils/nnn/Makefile,v
> retrieving revision 1.22
> diff -u -p -r1.22 Makefile
> --- Makefile 24 Nov 2022 10:25:40 -0000 1.22
> +++ Makefile 1 Jan 2023 19:12:45 -0000
> @@ -3,6 +3,7 @@ COMMENT = the missing terminal file bro
> V = 4.7
> DISTNAME = nnn-v${V}
> PKGNAME = nnn-${V}
> +REVISION = 0
>
> CATEGORIES = sysutils
>
> @@ -26,6 +27,13 @@ RUN_DEPENDS = textproc/gsed
> MAKE_FLAGS = CFLAGS_OPTIMIZATION=
> FAKE_FLAGS = MANPREFIX="$(PREFIX)/man" \
> PREFIX="${PREFIX}"
> +
> +FLAVORS = nerd
> +FLAVOR ?=
> +
> +.if ${FLAVOR:Mnerd}
> +MAKE_FLAGS += O_NERD=1
> +.endif
>
> USE_GMAKE = Yes
> NO_TEST = Yes
> Index: pkg/DESCR
> ===================================================================
> RCS file: /home/cvs/ports/sysutils/nnn/pkg/DESCR,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 DESCR
> --- pkg/DESCR 7 May 2018 18:29:00 -0000 1.1.1.1
> +++ pkg/DESCR 1 Jan 2023 19:17:12 -0000
> @@ -18,3 +18,6 @@ Cool things you can do with nnn:
> - pin a directory you may need to revisit and jump to it anytime
> - lock the current terminal after a specified idle time
> - change directory on exit
> +
> +Flavors:
> + nerd - build with support for Nerd Fonts to display glyphs.