Sunday, February 26, 2023

[proposal] math/rstudio - depend on net/curl as default download method

Index: Makefile
===================================================================
RCS file: /cvs/ports/math/rstudio/Makefile,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile
--- Makefile 3 Aug 2022 15:13:25 -0000 1.11
+++ Makefile 17 Feb 2023 21:46:55 -0000
@@ -10,7 +10,7 @@ ONLY_FOR_ARCHS = ${LP64_ARCHS}
V = 1.3.959
COMMENT = Integrated Development Environment (IDE) for R
PKGNAME = rstudio-${V}
-REVISION = 7
+REVISION = 8
CATEGORIES = math x11

HOMEPAGE = https://www.rstudio.com/
@@ -62,8 +62,9 @@ LIB_DEPENDS = devel/boost \

RUN_DEPENDS = devel/desktop-file-utils \
misc/shared-mime-info \
- x11/gtk+3,-guic
-
+ x11/gtk+3,-guic \
+ net/curl
+
CONFIGURE_ARGS = -DBoost_INCLUDE_DIR="${LOCALBASE}/include" \
-DQT_QMAKE_EXECUTABLE="${LOCALBASE}/bin/qmake-qt5" \
-DQt5WebEngine_DIR="${LOCALBASE}/lib/qt5/cmake/Qt5WebEngine" \
Index: patches/patch-src_cpp_session_modules_SessionPackages_R
===================================================================
RCS file: patches/patch-src_cpp_session_modules_SessionPackages_R
diff -N patches/patch-src_cpp_session_modules_SessionPackages_R
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-src_cpp_session_modules_SessionPackages_R 17 Feb 2023 21:46:55 -0000
@@ -0,0 +1,16 @@
+Index: src/cpp/session/modules/SessionPackages.R
+--- src/cpp/session/modules/SessionPackages.R.orig
++++ src/cpp/session/modules/SessionPackages.R
+@@ -1252,7 +1252,11 @@ if (identical(as.character(Sys.info()["sysname"]), "Da
+ else if (identical(sysName, "Darwin")) {
+ posixMethod("curl")
+ }
+-
++
++ else if (identical(sysName, "OpenBSD")) {
++ posixMethod("curl")
++ }
++
+ else if (identical(sysName, "Linux")) {
+ method <- posixMethod("wget")
+ if (!nzchar(method))
Ping, with updated subject. The initial one was a bit unfortunate...

On 2/17/23 22:55, Volker Schlecht wrote:
> Cc: Maintainer
>
> Currently math/rstudio always reports
>
> "Unable to set a secure (HTTPS) download.file.method (no compatible
> method available in this installation of R)."
>
> at startup, which based on a sample size of one (me), may be confusing
> to users and take quite a while to track down.
>
> The attached patch
>
> * adds a RUN_DEPENDS on net/curl
> * adds a patch for RStudio to default to curl as default download method
> for OpenBSD, just as for Darwin and Linux.
>
> With that in place, installing packages from a https CRAN mirror works
> nicely for me.

No comments:

Post a Comment