Tuesday, February 28, 2023

Re: drawpile plist change: cmake problem?

Hi Stuart --

On 2/28/2023 11:51 AM, Stuart Henderson wrote:
> On 2023/02/08 20:31, Brian Callahan wrote:
>> Hi Stuart --
>>
>> On 2/8/2023 2:59 PM, Stuart Henderson wrote:
>>> Drawpile has been failing to package for a while (probably since the
>>> cmake update to 3.25.2, though I see nothing that looked relevant in
>>> cmake's changelog). The plist changed:
>>>
>>> --- /mnt/plist/i386/drawpile-2.1.17p0
>>> +++ /mnt/plist/i386/drawpile-2.1.17p0-new
>>> @@ -46,7 +46,6 @@
>>> @wantlib vpx.15.0
>>> @cwd /usr/local
>>> bin/drawpile
>>> -@symlink drawpile-2.1.17
>>> @bin bin/drawpile-2.1.17
>>> @bin bin/drawpile-srv
>>> @man man/man1/drawpile-srv.1
>>>
>>> Does anyone know what's going on? It might just be that all that's
>>> needed is a REVISION bump to acknowledge the change, but I'd kind of
>>> like to have a reason for that ..
>>>
>>
>> Someone (naddy?) reached out to me about this a few days ago. I am OK
>> with a bump if that fixes things. I am not a cmake expert, so I defer to
>> them if there is a better fix.
>>
>> ~Brian
>>
>
> So the additional file is a second copy of the binary, but unstripped.
>
> I propose updating to the newer release, and @commenting the extra file
> in PLIST. OK?
>

I thought Rafael sent me an update to 2.1.20, but maybe I am misremembering.

In any event, yes this is ok for me.

Thanks.

~Brian

No comments:

Post a Comment