Re: On the remaining syscall(2) or __syscall(2) use in ports

On Thu, Feb 23, 2023 at 04:29:41PM +0100, Theo Buehler wrote:
> Based on nm output generated by sthen back in November (which doesn't
> capture Go a.k.a. the elephant in the room) the following ports used
> syscall(2) or __syscall(2).
>
> It would be nice if the maintainers (or someone who cares) could take a
> closer look and send diffs to replace syscall(2) use by direct calls to
> the appropriate syscall (if possible).
>
[..]
>
> devel/openmpi (martin)
> memory_patcher_syscall() wrapper around various syscalls

openmpi has a configure knob:


Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/openmpi/Makefile,v
retrieving revision 1.39
diff -u -p -u -p -r1.39 Makefile
--- Makefile 1 Jul 2022 15:33:57 -0000 1.39
+++ Makefile 27 Feb 2023 09:58:55 -0000
@@ -2,18 +2,19 @@ COMMENT = open source MPI-3.1 implement

V = 4.1.4
DISTNAME = openmpi-$V
+REVISION = 0

-SHARED_LIBS += open-pal 7.0 # 70.2
-SHARED_LIBS += mca_common_sm 4.0 # 70.0
-SHARED_LIBS += mca_common_dstore 2.0 # 1.2
-SHARED_LIBS += open-rte 7.0 # 70.2
-SHARED_LIBS += mpi 7.0 # 70.2
-SHARED_LIBS += mpi_mpifh 2.0 # 70.0
-SHARED_LIBS += mpi_usempi_ignore_tkr 2.0 # 70.0
-SHARED_LIBS += mpi_usempif08 4.0 # 70.0
-SHARED_LIBS += mca_common_monitoring 2.0 # 70.0
-SHARED_LIBS += mca_common_ompio 4.0 # 70.2
-SHARED_LIBS += ompitrace 2.0 # 70.0
+SHARED_LIBS += open-pal 8.0 # 70.2
+SHARED_LIBS += mca_common_sm 5.0 # 70.0
+SHARED_LIBS += mca_common_dstore 3.0 # 1.2
+SHARED_LIBS += open-rte 8.0 # 70.2
+SHARED_LIBS += mpi 8.0 # 70.2
+SHARED_LIBS += mpi_mpifh 3.0 # 70.0
+SHARED_LIBS += mpi_usempi_ignore_tkr 3.0 # 70.0
+SHARED_LIBS += mpi_usempif08 5.0 # 70.0
+SHARED_LIBS += mca_common_monitoring 3.0 # 70.0
+SHARED_LIBS += mca_common_ompio 5.0 # 70.2
+SHARED_LIBS += ompitrace 3.0 # 70.0

CATEGORIES = devel

Index: patches/patch-configure
===================================================================
RCS file: patches/patch-configure
diff -N patches/patch-configure
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-configure 27 Feb 2023 09:58:55 -0000
@@ -0,0 +1,18 @@
+Index: configure
+--- configure.orig
++++ configure
+@@ -156103,12 +156103,12 @@ $as_echo "$compile_mode" >&6; }
+
+ # try to configure the component
+
+- # disable on MacOS/Darwin where it isn't used and the deprecated
++ # disable on MacOS/Darwin and OpenBSD where it isn't used and the deprecated
+ # syscall interface causes compiler warnings.
+ { $as_echo "$as_me:${as_lineno-$LINENO}: checking if memory patcher supports $host_os" >&5
+ $as_echo_n "checking if memory patcher supports $host_os... " >&6; }
+ case $host_os in
+- darwin*)
++ darwin* | openbsd*)
+ opal_memory_patcher_happy=no
+ ;;
+ *)