On Tue, Feb 28, 2023 at 02:43:38PM +0000, Stuart Henderson wrote:
> On 2023/02/28 15:00, Claudio Jeker wrote:
> > This is mainly a toolchain update of prometheus LTS to 2.37.6.
> > With this the patch-go_syscalls is no longer needed since x/sys/unix is
> > finally new enough.
> >
> > I lightly tested it.
>
> REVISION could be removed (though it's not really important).
REVISION? I did not see any REVISION in Makefile.
> OK.
>
> The newer x/sys/unix in this has the wrong syscall numbers in the
> definitions in zsysnum_openbsd_* but the usual functions have changed to
> the libc wrappers so they aren't using those definitions any more, so
> that's an improvement.
Yes, nothing should use the syscall numbers.
> gopkg.in/alecthomas/kingpin.v2/guesswidth_unix.go in the vendor dir
> uses syscall.Syscall6(syscall.SYS_IOCTL,...) but that's not one of the
> syscalls which previously used pad and changed, so no problem there
> for now. (And if that does become a problem later, there will be much
> bigger problems in go-land).
This should just use IoctlGetWinsize() instead of raw sysctls. Golang really
pushed everyone into an ugly corner by failing to provide basic
functionality.
--
:wq Claudio
No comments:
Post a Comment