Friday, March 03, 2023

Re: [new] security/paperkey

On Fri, Mar 03, 2023 at 10:11:01PM +0100, Omar Polo wrote:
> few nits on the Makefile:
>
> - please use https:// for the HOMEPAGE
Done

> - it's actually GPLv2+ (not *that* important)

I got GPLv2 from COPYING, I searched for word 'later', but no matches
which are significant. Where do you see that it's 'gplv2 or later'?

> - I'd avoid setting SEPARATE_BUILD for autotools, it doesn't gain
> anything really.
Done (got this hint from https://www.openbsd.org/faq/ports/guide.html)

> less important, but I'd also reword the COMMENT to something along the
> lines of "OpenPGP private key backup utility suitable for printing".
Done

> Otherwise it looks good to me; ok op@ to import it

Thanks for the review, next attempt attached.

No comments:

Post a Comment