Re: net/rpki-sample-data - question about EXTRACT_ONLY=

I wouldn't bother with the tiny optimisation of having do-install untar the
distfile - instead remove EXTRACT_ONLY= and use ${INSTALL_DATA} to copy it
from WRKSRC.

Don't set DISTFILES, just set EXTRACT_SUFX=.tgz

Lowercase start of COMMENT

--
Sent from a phone, apologies for poor formatting.

On 28 April 2023 15:55:31 Job Snijders <job@sobornost.net> wrote:

> Hi porters,
>
> kn@ and I are trying to make a port that installs a ton of RPKI sample
> data which will be used to improve rpki-client regress (if the pkg is
> installed)
>
> For some reason the below yields the following error, and we don't know
> why:
>
> feather$ make
> ===> Checking files for rpki-20230428
> `/usr/ports/distfiles/rpki-20230428T000152Z.tgz' is up to date.
>>> (SHA256) rpki-20230428T000152Z.tgz: OK
> ===> Extracting for rpki-20230428
> make: don't know how to make do-extract
> Stop in .
> *** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2699
> '/usr/ports/pobj/rpki-20230428/.extract_done': @cd
> /usr/ports/net/rpki-sampl...)
> *** Error 2 in /usr/ports/net/rpki-sample-data
> (/usr/ports/infrastructure/mk/bsd.port.mk:2600 'all': @lock=rpki-20230428;
> export _LOCKS_HEL...)
>
> Does one of you know? :-)
>
> Kind regards,
>
> Job
>
> -----------------------------------------
>
> COMMENT = Samples of RPKI data
> CATEGORIES = net
> HOMEPAGE = https://www.rpkiviews.org
> MAINTAINER = Job Snijders <job@openbsd.org>
>
> # public domain
> PERMIT_PACKAGE = Yes
>
> VDATE = 2023/04/28
> VTIME = T000152Z
> VERSION = ${VDATE:S/\///g}
> DISTNAME = rpki-${VERSION}${VTIME}
> PKGNAME = rpki-${VERSION}
> DISTFILES = ${DISTNAME}.tgz
>
> MASTER_SITES = https://dango.attn.jp/rpkidata/${VDATE}/ \
> http://josephine.sobornost.net/josephine.sobornost.net/rpkidata/${VDATE}/
>
> EXTRACT_ONLY = # empty
> PKG_ARCH = *
> NO_BUILD = Yes
> NO_TEST = Yes
>
> SAMPLE_DATA = ${PREFIX}/rpki-sample-data-${VERSION}
>
> do-install:
> ${INSTALL_DATA_DIR} ${SAMPLE_DATA}
> ${TAR} -xzf ${FULLDISTDIR}/${DISTNAME}.tgz -C ${SAMPLE_DATA} \
> -s /${DISTNAME}//
>
> .include <bsd.port.mk>