Tuesday, May 02, 2023

Re: [new] brogue-1.12

On 02/05, Omar Polo wrote:

>Instead, I'd follow what upstream suggests and ship a scripts that
>"cd" into $XDG_DATA_HOME/Brogue before running the game.

This is a nice trick! I dont thought about it in that way.


>I'm recluntant to patch like this an upstream software since while
>for now it could work fine, these kind of changes are very likely to
>break in future updates.

At first, I tried to fix all warnings in brogue, but there is a
hundreds of strcpy and other sprintf, so I gave up. I am glad to see
fewer patches in port, really.

>I'm attaching a tweaked tarball

Thank you a lot! I compared it with my and noticed few changes, that
seems very interesting for me. It was very educational.

>I'm sorry for removing most of your patches and void your efforts, but
>I think that in the long run it's better to use a wrapper script.

This is obviously better solution and I learn a lot from your version!
Thank you for your time and efforts.

I tested your tarball and everything works like a charm. Should I do
something else for this port?

No comments:

Post a Comment