Re: [NEW] devel/libnjs

Hi Landry,

On Sat, May 20, 2023 at 06:03:26PM +0200, Landry Breuil wrote:
> Le Thu, May 18, 2023 at 09:31:35PM +0000, Sergey A. Osokin a écrit :
> > Hi there,
> >
> > here's the port of nginx javascript static library for OpenBSD
> > ports tree.
> > Please let me know your thoughts, ask questions, provide comments.
>
> you should be able to use the various GH_PROJECT/GH_ACCOUNT/GH_TAGNAME
> variables instead of handrolling DISTFILES/MASTER_SITES/PKGNAME/WRKDIST.

That's exactly what I tried to use as a first step, however that didn't
work for me, so I decided to use this way.

> is only the static lib necessary in libnjs ? for both ports, why the
> auto/make patch, afaict, our sed supports s,X,Y, constructs..

The static library is necessary, and probably a shared library will
be available for the future releases on nginx javascript.

About the auto/make patch - the issue has been reported to the upstream,
the upstream's updated,
https://github.com/nginx/njs/commit/8a03334e27393fc2031f071830f9605f4373b0be
So, I'll remove that patch with the next release of nginx javascript.

> i dont think do-build is necessary, setting ALL_TARGET=libnjs njs should
> achieve the same.

Good catch, I'm going to re-work this part and let you know how
that works, thanks.

> why two ports, instead of a single, or eventually a MULTI_PACKAGE ? i
> suppose your hidden untold goal is to enable support in nginx, if so why
> not saying it upfront ?

That's good idea. Since those two (devel/libnjs and lang/njs) from
the different categories, not sure what's the best place to create
a port for both (similarly to www/unit, I believe).

Also, I'm going to enable nginx javascript support for www/unit, so
I'd like to create that the same way as I did that for FreeBSD and
NetBSD.

Thank you.

--
Sergey A. Osokin