Hi Landry,
On Tue, May 23, 2023 at 09:36:20AM +0200, Landry Breuil wrote:
> Le Tue, May 23, 2023 at 08:17:05AM +0100, Stuart Henderson a écrit :
> > On 2023/05/23 09:05, Landry Breuil wrote:
[...]
> > >
> > > You don't need the V variable in the Makefile, and it wasn't present in
> > > the Makefile sthen@ sent. Also, i still dont understand the need for the
> > > auto/make patch, which is not included in the commit you pointed at for
> > > the stat thingy (eg
> > > https://github.com/nginx/njs/commit/8a03334e27393fc2031f071830f9605f4373b0be)
Sorry for another confusion, and thanks Stuart for the right link.
Do you need me to fix the Makefile or that can be fixed on your side?
> > That patch is ok. One of the variables in the sed replacement has a
> > , in it (iirc it was -Wl,something) so it can't be used as a delimiter
> > for sed.
> >
> > https://github.com/nginx/njs/commit/e9d814a0a8c1857f78fdc85ed1461cb9101ebf4e
>
> Ah, thanks stuart for the explanation, now that makes sense :)
>
> ok to import then
Thank you.
--
Sergey A. Osokin
No comments:
Post a Comment