Re: [new] sysutils/lsblk

On 2023/05/30 19:33:11 +0200, Benjamin Stürz <benni+openbsd@stuerz.xyz> wrote:
> > The port itself looks fine to me, except for the permissions of
> > distinfo and PLIST... All files should be 0644 and directories 0755.
> Fixed, the problem was my umask of 027.
>
> > No need to send an updated tarball just for this however, whoever will
> > import it can easily fix it.
> Did it anyway + for the reasons below.
>
> >
> > OK op@ to import with perms fixed.
> >
> > Now, some misc nits that don't really affect the port:
> >
> > - you could set yourself as MAINTAINER for the port. It is not
> > required of course, but seems you seem to be the upstream too
> > you're qualified enough I'd say ;-)
> Done
>
> > - I'd drop -Werror from release tarballs. While it is super-useful
> > during development, it is a super-pita for packagers when the C
> > compiler gets updated.
> Done

still ok op@ to import.

Thank you!