On Tue, May 23, 2023 at 07:09:51AM -0000, Stuart Henderson wrote:
> On 2023-05-23, David Gwynne <david@gwynne.id.au> wrote:
> > On Sat, May 20, 2023 at 09:44:51AM +0200, Holger Glaess wrote:
> >> hi
> >>
> >>
> >> looks like that the patch works , but should not print "tunneldomain"
> >> instead of "rdomain" ?
> >
> > that's an interesting question.
> >
> > ifconfig does not aim to produce output that can then be used as input
> > for ifconfig again. printing it as rdomain is at least consistent with
> > how it's printed on the tunnel: line for things like etherip and gif,
> > and i guess the assumption is you can figure out that it's tunneldomain
> > from the context.
>
> things are a bit inconsistent here - doesn't this actually take an rtable
> not an rdomain? (wg uses and prints "wgrtable" for what I think is the
> equivalent thing).
I think this is a general issue with tunneldomain. It should be
tunneltable since it used for two things. The route lookup of the tunnel
endpoints and to alter the mbufs rdomain on encapsulation / decapsulation.
At least in theory this is how it should work but someone needs to verify
that all drivers really behave like this.
--
:wq Claudio
No comments:
Post a Comment