On 2023/05/02 19:18:00 +0100, Stuart Henderson <stu@spacehopper.org> wrote:
> On 2023/05/02 11:37, Laurent Cheylus wrote:
> > Hi,
> >
> > an update for devel/goreleaser with the latest version 1.17.2.
> >
> > goreleaser is a Go tool to deliver Go binaries as fast and easily as
> > possible => https://goreleaser.com/
> >
> > - update Makefile and modules.inc for version 1.17.2 => build is OK on amd64
> > with Go 1.20.1
> > - update Makefile and pkg/PLIST to add shell completion for bash/fish/zsh
> >
> > Build and tests OK on current/amd64.
> >
> > Unless there's any objections, I'd like to take maintainership for this
> > port. I'm using this tool for my Go projects.
> >
> > Comments welcome and please commit if OK.
> >
> > Laurent
> >
>
> TMPDIR is a special variable and overriding it can cause problems
> sometimes (it's normally set in the environment to /tmp and used by
> various things; setting in a port Makefile can make it into the
> environment actually used for the build in some cases).
>
> I don't think there's a need for any special dir for that at all,
> we can just write the generated completion files to ${WRKSRC}.
+1
> So I'd use the below Makefile diff instead (I won't include the
> other ~13000 lines of diff again :)
>
> Otherwise looks good to me, it will be some time before my machine
> ends up fetching the 4100 distfiles to do any testing but I'm
> basically ok with it.
I have virtually the same diff locally (I used WRKBUILD rather than
WRKSRC, but it's fine either the way) and seems to be fine. I wanted
to double check modules.inc but it filled my /tmp/ with 3.5G of random
crap^Wgit repos before failing.
ok op@
No comments:
Post a Comment