- the Makefile comment about FindCairo.cmake is outdated/confusing
- please drop those sprintf->snprintf patches, you can try sending
them upstream if you like, there's not really a need for that in ports
- BUILD_DEPENDS looks wrong; don't list extract dependencies there, that's handled by ports infrastructure. what is gtk+4 for in there?
- don't hardcode CMAKE_BUILD_TYPE, that's handled by the cmale module
- any reason why you don't have COMPILER=base-clang ports-gcc?
On 2023/05/26 09:30, Johannes Thyssen Tishman wrote:
> Hi Stefan,
>
> > Looks good now.
> >
> > OK for import sdk@
>
> Awesome, thanks for that. Please find attached the port with the
> following last minute tweaks:
>
> - Formated DESCR based on your suggestions
> - Updated DESCR to match description on solvespace's website
> - Dropped Jerome KASPER from MAINTAINER as per his request
>
> Thanks again :)
>
> Kind regards,
>
> --
> Johannes Thyssen Tishman
> https://thyssentishman.com
>
No comments:
Post a Comment