I updated megacmd files with your mentions:
1) Sorted the variables as per Makefile.template
2) Renamed the sdk distname
3) Set DISTFILES once
4) I don't add bash as RUN_DEPENDS because it isn't need to use
megacmd, works well with other shells, I use with the default ksh
5) gtest to TEST_DEPENDS
6) Splitted and sorted CONFIGURE_ARGS
7) Consistently use of variable declarations
8) Fix PLIST
9) Remove AI_V4MAPPED from http.cpp, and fix http.h patch to not declare that
10) Use shared libs (I forgot why I used the static library…)
11) I don't split the sdk library, as use this only megacmd and not
possible to set the sdk libs as external dependency in configure
script of megacmd
12) patching megacmd to use the default bash-completion path
13) Change DESCR
I built and tested on -current, works for me.
Robert Bagdan <kikadf.01@gmail.com> ezt írta (időpont: 2023. jún. 15.,
Cs, 18:05):
>
> Thanks to your reviews, I will install -current OpenBSD to a vm in the
> next few days, and fix this port with your modifications and
> proposals.
> I will come back soon.
>
> Stuart Henderson <stu@spacehopper.org> ezt írta (időpont: 2023. jún.
> 15., Cs, 9:24):
> >
> > On 2023/06/14 13:13, Omar Polo wrote:
> >
> > > the patches seemed fine for me. I'd wish we could avoid patching for
> > > ereadline.
> >
> > that's normal for our renamed ports version of readline.
> >
> > > The only odd one is patches/patch-sdk_include_mega_http_h which
> > > defines AI_V4MAPPED...
> >
> > sdk/include/mega/http.h
> > 44-
> > 45-#if defined(__FreeBSD__) || defined(__OpenBSD__)
> > 46-#include <netinet/in.h>
> > 47:#define AI_V4MAPPED 0x00000800
> > 48-
No comments:
Post a Comment