Re: New: xclickroot

Omar Polo <op@omarpolo.com> wrote:

> On 2023/05/28 21:53:50 +0100, Alexander Arkhipov <aa@manpager.net> wrote:
> > Hello,
> >
> > xclickroot is an X program for running commands on clicking the root
> > window. It seems to build very cleanly, and so far I've encountered no
> > problems with it. The port's tarball is attached to this letter.
> >
> > Any comments? Thanks.
> >
> > https://github.com/phillbush/xclickroot
>
> looks fine, thanks!
>
> Only one nit: it doesn't respect CFLAGS from the ports infrastructure.
> When passing CFLAGS we need to add -I too because it doesn't pass
> CPPFLAGS to the ${CC} invocation.
>
> Attaching a diff against your makefile and an updated tarball that's
> OK op@ to import.
>
>
> Cheers,
>
> Omar Polo
>
> --- Makefile.orig Mon May 29 07:51:02 2023
> +++ Makefile Mon May 29 07:52:45 2023
> @@ -13,7 +13,8 @@
>
> WANTLIB += X11 c
>
> -MAKE_FLAGS = MANPREFIX=${TRUEPREFIX}/man
> +MAKE_FLAGS = CFLAGS="${CFLAGS} -I${X11BASE}/include" \
> + MANPREFIX=${TRUEPREFIX}/man
>
> NO_TEST = Yes
>
>

I've been further talking with the program's author. xclickroot is now
at version 1.4.0, with improvements to the build system and pledging. I
tested the port with the new Makefile, and it works fine.

Sending the diff and the tarball.

Thank you.

Alexander


--- Makefile.orig Sun Jun 4 21:18:39 2023
+++ Makefile Sun Jun 4 21:15:44 2023
@@ -2,7 +2,7 @@

GH_ACCOUNT = phillbush
GH_PROJECT = xclickroot
-GH_TAGNAME = v1.3
+GH_TAGNAME = v1.4.0

CATEGORIES = x11
HOMEPAGE = https://github.com/phillbush/xclickroot
@@ -13,8 +13,11 @@

WANTLIB += X11 c

-MAKE_FLAGS = CFLAGS="${CFLAGS} -I${X11BASE}/include" \
- MANPREFIX=${TRUEPREFIX}/man
+FAKE_FLAGS = PREFIX=${PREFIX} \
+ MANPREFIX=${PREFIX}/man
+
+MAKE_FLAGS = PREFIX=${TRUEPREFIX} \
+ MANPREFIX=${PREFIX}/man

NO_TEST = Yes