Re: [update] add desktop file to net/unison

Le 07/06/2023 à 06:30, Bjorn Ketelaars a écrit :
> On Tue 06/06/2023 23:38, Joel Carnat wrote:
>> Hello,
>>
>> I have seen that Unison does not have a launch icon in my XFCE whisker menu.
>> Looking at https://github.com/bcpierce00/unison/issues/162, a PR has been
>> submitted in 2018 but it is still opened and unresolved.
>>
>> Using the unison.desktop file from ArchLinux, this patch adds the file to
>> the OpenBSD port. Not sure if it's the proper way to do it but I use the
>> patch feature to create the unison.desktop from NULL.
>>
>> Attached is the patch to create the unison.desktop and the cvs diff to the
>> port.
>
> Some comments:
> - REVISION starts at 0
> - !no_x11 flavor has a run dependency on devel/desktop-file-utils
> - Instead of creating unison.desktop from NULL just have it in
> ${FILESDIR}
> - !no_x11 flavor specific bits should be placed in PFRAG.no-no_x11
>
> Could you check if the diff below works for you?
>
<snip>

Yes, it compiles and runs fine for me (OpenBSD 7.3-current #1215 on amd64) .

One note, in case it matters, applying your diff from a cleaned CVS
directory created unison.desktop and unison.desktop.orig in
/usr/ports/net/unison. I had to create a files/ directory manually
before applying the diff to get the unison.desktop files inside the
files/ directory.

Take care,
Joel C.