Re: [new] games/dsda-doom

On 2023/07/25 12:06, Lucas de Sena wrote:
> On 2023-07-24, Thomas Frohwein wrote:
> > 1. There are dependencies/WANTLIBS missing:
>
> Fixed.

Missing lib: mad.2 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
Missing lib: portmidi.0 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
Missing lib: vorbis.9 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
Missing lib: vorbisfile.6 (/usr/local/bin/dsda-doom) (NOT REACHABLE)
Missing lib: zip.4 (/usr/local/bin/dsda-doom) (NOT REACHABLE)

you need to add LIB_DEPENDS for the "NOT REACHABLE" ones, and re-run
the check to pick up the additional WANTLIB.

> > 3. What is the value of disabling fluidsynth in the Makefile? We have
> > it in ports...
>
> It needs fluidsynth 2.0, we have 1.1.9 packaged.

please add a comment explaining that.

you have this,

CONFIGURE_ENV = CFLAGS="-I${X11BASE}/include -I${LOCALBASE}/include"

which overrides the default CFLAGS. Instead use

CFLAGS += -I${X11BASE}/include -I${LOCALBASE}/include

also remove the two -DCMAKE_BUILD_TYPE lines, they are handled
by ports infrastructure.