Re: [New] luasteam - Steam intermediary for running some games made with games/love

On 2023/07/30 16:39:41 -0400, Thomas Frohwein <tfrohwein@fastmail.com> wrote:
> On Sat, Jul 22, 2023 at 07:01:44PM -0400, Thomas Frohwein wrote:
> > Hi,
>
> *ping*
> with updated tarball that includes patches/patch-src_user_cpp that
> fixes build with the just-updated goldberg_emulator steam SDK 1.57 API.
>
> ok?

can't really test at runtime but it looks fine for me. two
questions/nits:

- instead of installing luasteam.so in $PREFIX/lib, shouldn't
$PREFIX/lib/lua/5.1/ be a better place? it's in the default luajit
package.cpath so it should be picked up automatically without
setting LUA_CPATH.

- in patch-src_common_hpp I would have avoided the #ifdef __OpenBSD__
and just change the include to <steam_api.h> as done in
patch-src_gameServer_cpp

otherwise ok to import.

(I'd also add a comment before MAKE_FLAGS to explain that we're
abusing CXXFLAGS since the makefile doesn't honour LDFLAGS, LIBS,
CPPFLAGS etc..)