30.07.2023 17:43, Lucas пишет:
> Klemens Nanni <kn@openbsd.org> wrote:
>> LIB_DEPENDS have corresponding WANTLIB entries as a port links against
>> them; afaik gettext,-runtime is only needed for pkg_add hooks on these
>> .mo files, your port certainly does not link against it.
>
> Well, I copied it over from some other port:
>
> grep -Flr devel/gettext,-runtime net/
>
> shows it's used as an LDEP a lot of time, for example. I just tried
> making it an RDEP and the port still packages and works fine, and
> portcheck is still happy (except for the overlong line for GitHub). That
> being said, ldd shows that in both cases (as an LDEP and as an RDEP) the
> binary links against libintl.so, provided by gettext,-runtime, so I
> opted to keep it as an LDEP.
Right, libintl, then of course the LIB_DEPENDENCY is correct.
> Transmission is mainly a daemon, but upstream actually provides 4
> clients in the same repository as the daemon:
>
> - one simple CLI client
> - one full-fledged CLI client
> - a Qt client that can either run its own daemon or connect to a remote
> one
> - a GTK client that can only run its own daemon
>
> This is a GTK client that runs exclusively against a running daemon,
> which is slightly implied by the "remote" in the name. Nevertheless, I
> forgot about checking transmission-gtk COMMENT, so I rewrote it to
>
> GTK client for remote Transmission daemon
>
>> You disable the systray/appindicator feature, is that not useful in DEs
>> like GNOME 3 or Xfce4?
>
> It depends on a "libappindicator", which doesn't seem to be present in
> our tree, according to pkglocate.
I see we have x11/libappindicator, but it has been unhooked since import
in 2020, apparently because many ports would pick it up.
>
>> Why is the geoip feature disabled?
>
> It depends on headers GeoIP.h and GeoIPCity.h, again seemingly missing,
> according to pkglocate.
>
>> Please expand HOMEPAGE inside MASTER_SITES.
>
> Done.
>
> Updated port attached. It still works fine with my daemon. Thanks for
> the review, Klemens.
This port looks fine to me, builds and starts without problems.
Further Feedback?
OK to import?
>
> -Lucas
>
No comments:
Post a Comment