On Mon, Jul 31, 2023 at 10:17:05PM +0000, Klemens Nanni wrote:
> 'make patch' on a WXNEEDED=Yes port without wxallowed fails after
> patching and before creating the patch cookie, so subsequent setting
> of the option and rerunning the target will try to patch again.
>
> If the check is done right after extract, rerunning that target usually
> has higher chances of just working.
>
> Is there a reason I'm not aware of that this is done after patch?
>
>
> I just forgot to set wxallowed on /usr/ports/pobj when building
> ungoogled-chromium where 'make clean && mount ... && make patch' takes
> considerably longer than 'mount ... && make extract' to recover from
> forgetting to set wxallowed.
Personally, having it in extract step might be not convenient as extracting will
require 'wxallowed', even if I just want to extract to look at source code.
Ideally, I would put such control code at start of 'configure' step.
--
Sebastien Marie
No comments:
Post a Comment