Re: NEW: misc/libcpucycles

It's only been like 3 days..please have more patience

On 2023/08/07 20:01, Miguel Landaeta wrote:
> Ping?
>
> On Fri, Aug 4, 2023 at 10:44 PM Miguel Landaeta <miguel@miguel.cc> wrote:
> >
> > Thanks for the feedback.
> >
> > I attached a fixed version of the port.
> >
> > On Thu, Aug 3, 2023 at 11:04 PM Stuart Henderson <stu@spacehopper.org> wrote:
> > >
> > > Make sure that you can still produce a package if the 0.0 in
> > > SHARED_LIBRARIES is changed (you probably need to pass
> > > ${LIBcpucycles_VERSION} in to the build).
> >
> > Got it. I was missing this in my first revision. I reworked one of the patches
> > and verified that I can update the library version if/when required.
> >
> > > : MODULES+= lang/python
> > > : BUILD_DEPENDS= lang/python/${MODPY_DEFAULT_VERSION_3}
> > >
> > > BUILD_DEPENDS is automatically set by the python module, this isn't
> > > needed.
> >
> > Fixed.
> >
> > >
> > > > Description:
> > > > libcpucyples provides a simple API to access hardware precise timers
> > > typo ^
> > >
> >
> > Silly typo, fixed.
> >
> > > > +Small adjustments to make library manpage consistent
> > > > +Index: doc/man/cpucycles.3
> > >
> > > Unless necessary to make it work, I'd skip those.
> >
> > Ack. It makes more sense to fix it upstream.
>
> --
> Miguel Landaeta, miguel at miguel.cc
> secure email with PGP 0x6E608B637D8967E9 available at http://keyserver.pgp.com/
> "Faith means not wanting to know what is true." -- Nietzsche
>