Saturday, September 30, 2023

Re: sysutils/rofi sometimes coredumps in __vfprintf (+ similar crash in fvwm3)

On Sat, Sep 30, 2023 at 11:00:10AM +0200, Omar Polo wrote:
> I managed to reproduce it. It doesn't seem to fail with CWM, so I run
> fvwm3 inside Xephyr.
>
> The issue seems to be in source/xcb.c:
>
> (gdb) p wtitle.strings
> $2 = 0xf9d9ce2ce30 "FVWM", '\004' <repeats 12 times>, '\337' <repeats 183 times>, <incomplete sequence \337>...
>
> wtitle.strings is not NUL terminated, so it later crashes in strlen
> (via __vfprintf) after it goes out of the bounds.
>
> This seems to fix it, but I'm not knowledgable enough to tell whether
> this is a FVWM3 issue. (i assume so tho since it's intermittent.)
>
> Can you give this diff a spin? I don't use nor rofi anymore nor
> fvwm3.

No crash in 100 iterations, thanks for the fix.

No comments:

Post a Comment