Re: [new] www/gallery-dl

grodzio@waifu.club wrote (2023-10-29 09:31 CET):
> Attached is a port of gallery-dl, a Python script for downloading
> images in bulk from various image hosting websites. I've tested the
> port on amd64, works correctly on my end.
>
> URL to the port tarball (can't send it in the email, my apologies):
> https://grd1.1337.cx/files/gallery-dl-1.26.1.tar.gz
>
> The script can use optional run dependencies for additional
> functionality, I've included a list of them in DESCR and MESSAGE.
>
> I'm willing to maintain the port. Feedback and testing appreciated.
> -grodzio1

Hi,

thanks for the submission. It works and looks good for a first port.
I have some remarks.

> VERSION = 1.26.1
> MODPY_EGG_VERSION = ${VERSION:S/.0/./g}

The regular expression here is not needed.

> COMMENT = Python script for downloading images from websites

Start lowercase here. I also think it's not important that this is a python script.
My suggestion would be something like:
CLI program to mass download images from various websites

> pkg/MESSAGE
> pkg/DESCR

The DESCR file should only contain information about what the application is / does.
It's not supposed to contain instructions.

The MESSAGE file is shown once when the package is installed. This is also not
a suitable place for instructions. These should to to pkg/README.

And the last thing would be about the sorting of the elements.
We usually align the sequence to the template in
/usr/ports/infrastructure/templates/Makefile.template

Attached is a modified port with these changes.