Saturday, October 28, 2023

Re: x11/qt5/qtwebengine syscall(2) removal

On Sun Oct 29, 2023 at 07:35:40AM +0100, Theo Buehler wrote:
> On Sun, Oct 29, 2023 at 07:21:00AM +0100, Rafael Sadowski wrote:
> > Simple diff to remove sysvall(2), feedback, ok?
>
> > ++ int err = futex(reinterpret_cast<volatile unsigned int *>(&state_), FUTEX_WAIT | FUTEX_PRIVATE_FLAG,
> > ++ kLockedContended, nullptr, nullptr)
>
> Why do you cast to unsigned int and not uint32_t?
>
> Both the qt5 and the qt6 diffs read fine, ok tb

I did that too, but I checked it with www/chromium and decided to go
with that cast.

www/chromium/patches/patch-base_allocator_partition_allocator_spinning_mutex_cc

No comments:

Post a Comment