Hi Stefan,
On Tue, 31 Oct 2023 18:43:35 +0100, Stefan Hagen wrote:
> port-lib-depends-check:
> Extra: c++.9
>
> I think we can drop ${COMPILER_LIBCXX}, because everything included
> there, is also included in ${MODCARGO_WANTLIB} - except c++.
>
> $ make show=COMPILER_LIBCXX c++ c++abi pthread
>
> $ make show=MODCARGO_WANTLIB c pthread c++abi
You're right: we can drop ${COMPILER_LIBCXX} => c++ lib. dependency not
necessary.
> I'm not sure about the COMPILER line. I'd think that the cargo module
> takes care of this. But it doesn't set COMPILER and there's one
> non-clang arch in RUST_ARCHS (sparc64).
Yes, COMPILER is defined to build this port on sparc64 (no Clang on this
arch).
> OK from your side?
OK with your modification: build and tests OK on current/amd64.
Thanks for your review, Laurent
No comments:
Post a Comment