Re: devel/p5-IPC-Shareable?? Update to 1.13

On Fri, Dec 08, 2023 at 06:30:44AM +0000, wen heping wrote:
> Hi, ports@:
>
> Here is a patch for devel/p5-IPC-Shareable to update to 1.13 and
> add missing RUN_D and TEST_D.
> It build well and pass all tests on amd64-current system.

You should set MAKE_ENV = CI_TESTING=1
Otherwise nothing is tested.

> One port depends on devel/p5-IPC-Shareable, net/inetsim
> build well and run well(should adjust kern.seminfo.semmni=20)
> with this patch, no test defined.

The tests in p5-IPC-Shareable also require sysctl kern.seminfo.semmni=20
I wonder if we could add this in some make target. Or at least as
comment.

And with this, one test still fails:

IPC-Shareable-1.13$ CI_TESTING=1 perl -I blib/lib/ t/99-end.t
ok 1 - use IPC::Shareable;
ERROR: Could not acquire shared memory segment... 'create' option is not set, and the segment hasn't been created yet:

No such file or directory at blib/lib/IPC/Shareable.pm line 751.
IPC::Shareable::_tie("HASH", "IPC::Shareable", HASH(0xae1dca1a190)) called at blib/lib/IPC/Shareable.pm line 124
IPC::Shareable::TIEHASH("IPC::Shareable", HASH(0xae1dca1a190)) called at t/99-end.t line 17
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 2 just after 1.

bluhm

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/p5-IPC-Shareable/Makefile,v
> retrieving revision 1.10
> diff -u -p -r1.10 Makefile
> --- Makefile 11 Mar 2022 18:51:37 -0000 1.10
> +++ Makefile 8 Dec 2023 06:25:16 -0000
> @@ -2,11 +2,17 @@ COMMENT = share Perl variables between p
>
> MODULES = cpan
> PKG_ARCH = *
> -DISTNAME = IPC-Shareable-0.61
> +DISTNAME = IPC-Shareable-1.13
> CATEGORIES = devel
> -REVISION = 1
>
> # GPLv2
> PERMIT_PACKAGE = Yes
> +
> +RUN_DEPENDS = converters/p5-JSON \
> + devel/p5-String-CRC32
> +TEST_DEPENDS = devel/p5-Mock-Sub \
> + devel/p5-Test-SharedFork
> +
> +MAKE_ENV += TEST_POD=1 RELEASE_TESTING=1
>
> .include <bsd.port.mk>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/devel/p5-IPC-Shareable/distinfo,v
> retrieving revision 1.2
> diff -u -p -r1.2 distinfo
> --- distinfo 14 Apr 2014 14:02:43 -0000 1.2
> +++ distinfo 8 Dec 2023 06:25:16 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (IPC-Shareable-0.61.tar.gz) = wv+lu9oHas2fwbfZ2rHOZwfzRcWoM0MbWo7g+HRHIMQ=
> -SIZE (IPC-Shareable-0.61.tar.gz) = 29730
> +SHA256 (IPC-Shareable-1.13.tar.gz) = RW5mX3Kj+3ulqOcOMhz8nIJZ3vsxEbUZQK0IyrnADms=
> +SIZE (IPC-Shareable-1.13.tar.gz) = 51682
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/devel/p5-IPC-Shareable/pkg/PLIST,v
> retrieving revision 1.2
> diff -u -p -r1.2 PLIST
> --- pkg/PLIST 11 Mar 2022 18:51:37 -0000 1.2
> +++ pkg/PLIST 8 Dec 2023 06:25:16 -0000
> @@ -2,5 +2,6 @@ ${P5SITE}/IPC/
> ${P5SITE}/IPC/Shareable/
> ${P5SITE}/IPC/Shareable.pm
> ${P5SITE}/IPC/Shareable/SharedMem.pm
> +${P5SITE}/IPC/ipc.pl
> @man man/man3p/IPC::Shareable.3p
> @man man/man3p/IPC::Shareable::SharedMem.3p